feat: V4 create behind feature flag [1/n] #4444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
johnnyd-eth
commented
Aug 29, 2024
•
johnnyd-eth
commented
- Copies v2v3 create dir to v4
- Modify pages/create to enable v4 behind feature flag, plus wrap v4 in required Providers: https://github.com/jbx-protocol/juice-interface/pull/4444/files#r1735464428
johnnyd-eth
force-pushed
the
v4-edit-cycle-review-3
branch
from
e629a1a to
239552a
Compare
johnnyd-eth
commented
Aug 29, 2024
There was a problem hiding this comment.
Main diff here
johnnyd-eth
commented
Aug 29, 2024
| const [loading, setLoading] = useState(true) | ||
|
|
||
| useEffect(() => { | ||
| if (!router.isReady || !contracts.primaryNativeTerminal.data) return |
There was a problem hiding this comment.
Terminal address loaded for network given here: https://github.com/jbx-protocol/juice-interface/pull/4444/files#r1735468140
johnnyd-eth
commented
Aug 29, 2024
| <WagmiProvider config={wagmiConfig}> | ||
| {/* Hardcode V4 create to Sepoila for now */} | ||
| <JBProjectProvider | ||
| chainId={NETWORKS_BY_NAME[NetworkName.sepolia].chainId as 11155111} |
There was a problem hiding this comment.
Sets the network for useJBContractContext to use. Ideally we would read from process.env.NEXT_PUBLIC_INFURA_NETWORK, but I think this will require us to first update jbDirectoryAddress in the SDK to include mainnet (chainId=1):
johnnyd-eth
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.